Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EK bugfixes #4106

Merged
merged 10 commits into from
Jan 27, 2021
Merged

EK bugfixes #4106

merged 10 commits into from
Jan 27, 2021

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Jan 25, 2021 •
edited
Loading

Description of changes:

  • fix broken EK_DEBUG feature (compiler error, -Wconversion warnings, memory leak)
  • fix broken EK species ion[i,j,k].flux getter
  • fix broken EK VTK files
  • improve EK testing
  • merge the per-axis EK EOF tests into a template test

@jngrad jngrad added this to the Espresso 4.2 milestone Jan 25, 2021
@jngrad jngrad marked this pull request as ready for review January 25, 2021 17:09
@jngrad jngrad requested a review from reinaual January 27, 2021 13:00
@reinaual reinaual added the automerge Merge with kodiak label Jan 27, 2021
@kodiakhq kodiakhq bot merged commit 71bdc0c into espressomd:python Jan 27, 2021
@jngrad jngrad deleted the ek_maintenance branch January 27, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinaual reinaual reinaual approved these changes

@mkuron mkuron mkuron approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak BugFix Core Python Testcase
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jngrad @mkuron @reinaual