Update build system for Clang 10 #4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use sm_52 for CUDA 11 and sm_30 for CUDA 10.
The latest version has fixed -Wimplicit-float-conversion and has added missing includes.
Source files from external libraries are ignored by Clang-Tidy. Header files from external libraries are not ignored when included in source files from the current project. For example with Clang 10, ScaFaCoS triggers multiple alerts, e.g. bugprone-macro-parentheses and modernize-deprecated-headers. However, Clang-Tidy ignores header files from folder included with -isystem instead of -I, so that you can exclude them by marking them as SYSTEM.
KaiSzuttor
previously approved these changes
Jan 13, 2021
|
There's no point in adding the automerge label if the CI infrastructure is down :-) |
so i cant express that i want to merge if our infrastructure is down? |
The merge commit will fail and kodiak will try to merge the following PRs in the queue, which will also fail. In the end we'll have merge commits everywhere, and once CI is up again, kodiak will have to introduce more merge commits since all PRs in the queue will outdate each other. We had this situation on December 19, if you remember. |
reinaual
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
-Wimplicit-float-conversioneverywhere (enabled by default in Clang 10 in constant expressions), fixes Implicit float conversions raise warnings in Clang 10 #4082SYSTEMmethod already used by Random123 and h5xx (ScaFaCoS raises several alerts in Clang-Tidy 10)sm_XYarchitecture(s) get compiled depending on the CUDA version