Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against ScaFaCoS fatal errors #4068

Merged
merged 4 commits into from
Dec 24, 2020
Merged

Guard against ScaFaCoS fatal errors #4068

merged 4 commits into from
Dec 24, 2020

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Dec 22, 2020

Description of changes:

  • catch runtime errors from ScaFaCoS at the python level instead of crashing ESPResSo
  • use standard exception mechanism when setting Coulomb and dipolar prefactors

@jngrad jngrad added this to the Espresso 4.2 milestone Dec 22, 2020
@reinaual reinaual added the automerge Merge with kodiak label Dec 24, 2020
@kodiakhq kodiakhq bot merged commit c197c76 into espressomd:python Dec 24, 2020
@jngrad jngrad deleted the scafacos-exceptions branch December 24, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinaual reinaual reinaual approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak BugFix Core Python
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jngrad @reinaual