Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement setter for particle director. #4053

Merged
merged 3 commits into from
Dec 20, 2020
Merged

Implement setter for particle director. #4053

merged 3 commits into from
Dec 20, 2020

Conversation

pkreissl
Copy link
Contributor

Fixes #1470

@pkreissl pkreissl force-pushed the particle_director_setter branch from 03fb8fb to 426240b Compare December 17, 2020 12:35
KaiSzuttor
KaiSzuttor reviewed Dec 17, 2020
View reviewed changes
src/python/espressomd/particle_data.pyx Outdated
property director:
"""
Director.
The particle director (z-axis in the body-fixed frame).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this still needs some more explanation for the user.

@RudolfWeeber
Copy link
Contributor

RudolfWeeber commented Dec 17, 2020 via email

@KaiSzuttor
Copy link
Member

i think this still needs some more explanation for the user.
There is a dedicated doc chapter on rotations in Es. One could link to that.

i could not find useful information in the sphinx documentation when i searched for the director keyword

@jngrad jngrad added this to the Espresso 4.2 milestone Dec 19, 2020
@jngrad jngrad added automerge Merge with kodiak Core Python labels Dec 19, 2020
@jngrad jngrad added the BugFix label Dec 19, 2020
@espressomd espressomd deleted a comment from espresso-ci Dec 19, 2020
@jngrad jngrad added automerge Merge with kodiak and removed BugFix automerge Merge with kodiak labels Dec 19, 2020
@kodiakhq kodiakhq bot merged commit 46001f9 into espressomd:python Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiSzuttor KaiSzuttor KaiSzuttor left review comments

@RudolfWeeber RudolfWeeber RudolfWeeber approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak Core Python
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging this pull request may close these issues.

Implement setting of particle director
4 participants
@pkreissl @RudolfWeeber @KaiSzuttor @jngrad