-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added check if particles are not in ELC gap region #4051
Conversation
please use |
I tried, but doesn't work on my local machine properly yet ... It didn't do anything. Sorry. |
43cbbca
to
664b477
Compare
Your pull request does not meet our code formatting rules. Specifically, I suggest you make the following changes: diff --git a/testsuite/python/elc.py b/testsuite/python/elc.py
index 24cb9c9e7..c1d9a9085 100644
--- a/testsuite/python/elc.py
+++ b/testsuite/python/elc.py
@@ -85,5 +85,6 @@ class ElcTest(ut.TestCase):
with self.assertRaises(Exception):
self.integrator.run(2)
+
if __name__ == "__main__":
ut.main() To apply these changes, please do one of the following:
You can run Please note that there are often multiple ways to correctly format code. As I am just a robot, I sometimes fail to identify the most aesthetically pleasing way. So please look over my suggested changes and adapt them where the style does not make sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Could you please amend these two paragraphs to explain the method will throw if particles enter the gap? espresso/doc/sphinx/electrostatics.rst Lines 258 to 259 in 2518718
espresso/doc/sphinx/magnetostatics.rst Lines 99 to 100 in 2518718
After that you can remove the WIP from the title, and we're good to merge. |
Fixes Issue #4009
Description of changes: