Fix clearing the list of actors #4037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of actors cannot be cleared completely because the size of the list changes during iteration, leading to early exit. This bug is present since release 4.0.0.
RudolfWeeber
approved these changes
Dec 14, 2020
KaiSzuttor
reviewed
Dec 14, 2020
| @@ -231,8 +231,8 @@ class Actors: | |||
|
|
|||
| def clear(self): | |||
| """Remove all actors.""" | |||
| for a in self.active_actors: | |||
| self.remove(a) | |||
| while len(self.active_actors): | |||
There was a problem hiding this comment.
why don't we use the clear method of python lists?
KaiSzuttor
reviewed
Dec 14, 2020
| @@ -231,8 +231,8 @@ class Actors: | |||
|
|
|||
| def clear(self): | |||
| """Remove all actors.""" | |||
| for a in self.active_actors: | |||
| self.remove(a) | |||
| while len(self.active_actors): | |||
There was a problem hiding this comment.
Suggested change
| while len(self.active_actors): | |
| self.active_actors.clear() |
|
why don't we use the clear method of python lists?
IIRc, because actors have a hook for when they are being removed (turn stuff off in the core).
You cannot use Pythons __-hook, because the actual destruction of the object can be deferred by the garbage collection.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4033
Description of changes:
Actors.clear()method so that it removes all actors