Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: Removed feature UMBRELLA #4032

Merged
merged 1 commit into from
Dec 9, 2020
Merged

config: Removed feature UMBRELLA #4032

merged 1 commit into from
Dec 9, 2020

Conversation

fweik
Copy link
Contributor

@fweik fweik commented Dec 8, 2020

UMBRELLA used to enable umbrella sampling which does not exist anymore,
now it only controls a bonded interaction type which does not have an performance
impact so this is no longer needed. Also building with UMBRELLA was broken.

Description of changes:

  • Fixed build with UMBRELLA
  • Removed UMBRELLA as a compile-time feature

@KaiSzuttor KaiSzuttor added the automerge Merge with kodiak label Dec 9, 2020
@kodiakhq kodiakhq bot merged commit fb4a497 into espressomd:python Dec 9, 2020
@jngrad jngrad mentioned this pull request Dec 25, 2020
Closed
@jngrad jngrad added the Core label Jan 15, 2021
@jngrad jngrad added this to the Espresso 4.2 milestone Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngrad jngrad jngrad approved these changes

@KaiSzuttor KaiSzuttor KaiSzuttor approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak Core
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@fweik @KaiSzuttor @jngrad