Fix LB node interface #3978
Merged
Fix LB node interface #3978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this check, the method may return None.
The np.array() casts the entire array to string if the last element is a string, causing the assertion in LBFluidRoutines() to complain about the first element being a string, which it is not in the user input. The logic for the assertion in HydrodynamicInteraction() can also be replaced by utils.check_type_or_throw_except().
jngrad
force-pushed
the
lb-node-interface
branch
from
9f460ea to
926fce0
Compare
This <boost/serialization/version.hpp> include guards against an issue in boost::serialization from boost 1.74.0 that leads to compiler error "explicit specialization of undeclared template struct 'version'" when including <boost/serialization/optional.hpp>. More details in tickets: boostorg/serialization#210 boostorg/serialization#217
reinaual
approved these changes
Oct 29, 2020
KaiSzuttor
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
lbf[0,0].velocity) are now caughtlbf[0,0,0.1]) now produce the correct error messagelbf[0,0,0].velocity = np.array([0,0,0])