Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HarmonicDumbbell. #3974

Merged
merged 3 commits into from
Oct 26, 2020
Merged

Remove HarmonicDumbbell. #3974

merged 3 commits into from
Oct 26, 2020

Conversation

KaiSzuttor
Copy link
Member

Fixes #3964

@jngrad jngrad self-requested a review October 26, 2020 14:26
jngrad
jngrad previously approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jngrad jngrad added this to the Espresso 4.2 milestone Oct 26, 2020
@jngrad jngrad added the automerge Merge with kodiak label Oct 26, 2020
@fweik
Copy link
Contributor

fweik commented Oct 26, 2020

Iirc you can also remove the torque parameter from calc_bond_pair_force.

@jngrad jngrad removed the automerge Merge with kodiak label Oct 26, 2020
@jngrad jngrad added the automerge Merge with kodiak label Oct 26, 2020
@kodiakhq kodiakhq bot merged commit 33d5c74 into espressomd:python Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngrad jngrad jngrad approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging this pull request may close these issues.

Harmonic dumbbell bond uses parameters of harmonic bond interaction
3 participants
@KaiSzuttor @fweik @jngrad