Fix CMake compiler flags logic #3852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CMAKE_CXX_FLAGS CMake variable cannot be added directly to an INTERFACE target. This will duplicate it at the end of the list as a whole string, which can lead to a compiler error. For example, `CXXFLAGS="-O3 -Wall" cmake ..` will generate a compilation command in the form `c++ <flags> -O3 -Wall <flags> "-O3 -Wall" <filenames>`, which is incorrect (there is no optimization level "3 -Wall"). This will fail randomly depending on the compiler. This is incompatible with automated build systems such as RPM Build and OSC.
KaiSzuttor
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove non-standard CMake logic that appends a whitespace-separated list of compiler flags as a string at the end of a list, making it incompatible with automated build systems like RPM Build (Fedora) and OSC (OpenSUSE).