-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script interface Backend Replacement #3794
Conversation
Codecov Report
@@ Coverage Diff @@
## python #3794 +/- ##
=======================================
Coverage 89% 89%
=======================================
Files 554 560 +6
Lines 24166 24023 -143
=======================================
- Hits 21566 21457 -109
+ Misses 2600 2566 -34
Continue to review full report at Codecov.
|
@jngrad I don't understand the sphinx error, can you help me out? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't read everything, yet.
I'd really appreciate it if I could get some feedback on the design. |
I’m not totally clear about the role of ObjectManager yet.
Is its purpose to hide the concept of contexts from the client?
Why is there serialization code in the object manager. Is that just to save the creation policy along with the state of the object?
|
When restoring from serialization, a context is needed to create the objects in, this is why it is on the contex. Now that you mention it, maybe it would be better as a free function, let me try. The |
I've added some docs and move the serialization code to |
This function checks the size of the pointer, not the pointee.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok from my side
Thank you for adding the docs ;-) |
Description of changes
Variant
(shared) own contained objectsUtils::make_function
ScriptInterface::AutoParameter