WIP: short range and cells refactor #3787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #3787 +/- ##
=======================================
- Coverage 89% 89% -1%
=======================================
Files 554 549 -5
Lines 24166 23847 -319
=======================================
- Hits 21566 21277 -289
+ Misses 2600 2570 -30
Continue to review full report at Codecov.
|
… pair kernel application
…ndler by bond_loop
…f short_range_loop into CellStructure
…r, made part of the bond impl private
|
I currently don't have time to work on this. |
kodiakhq bot
added a commit
that referenced
this pull request
Sep 2, 2020
Rewrite of #3787 Description of changes: - simplify short range loop - remove `for_each_pair.hpp ` and `verlet_ia.hpp` helper functions - delegate distance calculation and cell iteration to the `CellStructure` class - hide implementation details of `CellStructure` - make `local_cells()` private - encapsulate debug functions - remove global variables `n_verlet_updates` and `rebuild_verletlist`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3780.
Exposition only for now.
Description of changes: