Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correlator maintainance #3783

Merged
merged 10 commits into from
Jun 30, 2020
Merged

Correlator maintainance #3783

merged 10 commits into from
Jun 30, 2020

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Jun 30, 2020

Description of changes:

  • Remove documentation of nonexistent correlator complex_conjugate_product
  • Remove unused, undocumented and untested correlator get_correlation_time
  • Update documentation of the tau_lin parameter and FCS correlator
  • Add testcase for the FCS correlator and the linear tau correlator

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #3783 into python will increase coverage by 0%.
The diff coverage is 90%.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3783   +/-   ##
======================================
  Coverage      88%     89%           
======================================
  Files         552     552           
  Lines       24446   24421   -25     
======================================
+ Hits        21714   21735   +21     
+ Misses       2732    2686   -46     
Impacted Files Coverage Δ
src/core/accumulators/Correlator.hpp 90% <ø> (ø)
src/core/accumulators/Correlator.cpp 85% <90%> (+13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cc0cd1...b59a527. Read the comment docs.

Copy link
Contributor

@fweik fweik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jngrad jngrad added the automerge Merge with kodiak label Jun 30, 2020
@kodiakhq kodiakhq bot merged commit e2c70d7 into espressomd:python Jun 30, 2020
@jngrad jngrad deleted the linear-correlator branch January 18, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants