Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Stomatocyte shape #3730

Merged
merged 2 commits into from
May 25, 2020
Merged

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented May 25, 2020

Stomatocyte is no longer used and hasn't been actively maintained since 4.0.

The code is untested and not well documented. Certain choices
of parameters can lead to NaN values, with no clear pattern.
@jngrad jngrad added this to the Espresso 4.2 milestone May 25, 2020
@jngrad jngrad requested a review from fweik May 25, 2020 14:30
@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #3730 into python will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #3730    +/-   ##
=======================================
  Coverage      88%     89%            
=======================================
  Files         551     548     -3     
  Lines       24669   24455   -214     
=======================================
+ Hits        21778   21784     +6     
+ Misses       2891    2671   -220     
Impacted Files Coverage Δ
src/script_interface/shapes/initialize.cpp 100% <ø> (ø)
src/core/particle_data.cpp 96% <0%> (+<1%) ⬆️
src/core/electrostatics_magnetostatics/p3m.cpp 87% <0%> (+<1%) ⬆️
src/core/polymer.cpp 98% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 724ea3d...5a67e37. Read the comment docs.

@jngrad jngrad added the automerge Merge with kodiak label May 25, 2020
@kodiakhq kodiakhq bot merged commit 4278feb into espressomd:python May 25, 2020
@jngrad jngrad deleted the remove-stomatocyte branch January 18, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ApiChange automerge Merge with kodiak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants