Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Reinit longrange stuff on manual cutoff or skin change #3717

Merged
merged 1 commit into from
May 15, 2020
Merged

core: Reinit longrange stuff on manual cutoff or skin change #3717

merged 1 commit into from
May 15, 2020

Conversation

fweik
Copy link
Contributor

@fweik fweik commented May 15, 2020

Description of changes:

  • (d)P3M depends on the local box size and skin (because this sets he bounding box for local particles), so it has to be reinitialized if they change.

@jngrad this is also a candidate for back porting.

@fweik
Copy link
Contributor Author

fweik commented May 15, 2020

Unfortunately I couldn't think of a reliable way to test this in a robust fash, as it depends on loads of other circumstances...

@jngrad jngrad added this to the Espresso 4.1.3 milestone May 15, 2020
@fweik fweik added the automerge Merge with kodiak label May 15, 2020
@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #3717 into python will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           python   #3717     +/-   ##
========================================
  Coverage      88%     88%             
========================================
  Files         529     545     +16     
  Lines       23213   24721   +1508     
========================================
+ Hits        20430   21781   +1351     
- Misses       2783    2940    +157     
Impacted Files Coverage Δ
src/core/event.cpp 94% <100%> (+<1%) ⬆️
src/core/EspressoSystemInterface.hpp 48% <0%> (-22%) ⬇️
src/script_interface/shapes/Torus.hpp 80% <0%> (-20%) ⬇️
src/script_interface/shapes/Rhomboid.hpp 87% <0%> (-13%) ⬇️
src/shapes/include/shapes/Rhomboid.hpp 88% <0%> (-12%) ⬇️
src/script_interface/shapes/Slitpore.hpp 90% <0%> (-10%) ⬇️
src/shapes/include/shapes/Slitpore.hpp 91% <0%> (-9%) ⬇️
src/script_interface/constraints/couplings.hpp 68% <0%> (-6%) ⬇️
src/script_interface/observables/PidObservable.hpp 72% <0%> (-6%) ⬇️
...ipt_interface/observables/PidProfileObservable.hpp 23% <0%> (-5%) ⬇️
... and 252 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6df110...944fb45. Read the comment docs.

@kodiakhq kodiakhq bot merged commit ff10b53 into espressomd:python May 15, 2020
@fweik fweik deleted the skin_care branch May 15, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants