-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor RDF as an observable #3706
Conversation
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
The RDF observable is kind of a stand-alone class. If we decide to port The time series documentation needs to be backported in 4.1.3. |
Codecov Report
@@ Coverage Diff @@
## python #3706 +/- ##
======================================
- Coverage 88% 88% -1%
======================================
Files 545 549 +4
Lines 24721 24747 +26
======================================
+ Hits 21779 21787 +8
- Misses 2942 2960 +18
Continue to review full report at Codecov.
|
} | ||
while (first1 != last1) { | ||
for (auto it = first2; it != last2; ++it) { | ||
if (*it != *first1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that comparison by value is what we want here. This limits the usability to value types that are comparable without need, and the behavior is different from for_each
(which does it != first
, e.g. shallow comparison), which is surprising. I think in the general algorithm the pairs should not be filtered, this can be implemented in the op. One could also implement a for_each_pair_if
on if wanted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was unsure about that solution too. If we remove that conditional, then we cannot decay this function to for_each_pair
, since that one removes diagonal elements. In fact, we probably don't want to decay in any case, because for_each_pair
also removes the symmetric pairs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've coded a for_each_cartesian_pair_if
and removed the decay to for_each_pair
.
If the user does not supply an ids2 parameter, calculate the RDF of ids1 against itself.
@KaiSzuttor did you have time to look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for some small tweaks.
Folllow-up to #3599
Description of changes:
statistics.cpp
TimeSeries