Generic observables #3667
Merged
Generic observables #3667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added basic CI See merge request kai/observables!1
Switched to pitchfork layout See merge request kai/observables!2
maintainer: added README file. See merge request kai/observables!3
Fixed general design See merge request kai/observables!4
pitchfork: removed subnamespaces. See merge request kai/observables!5
Algorithm type See merge request kai/observables!6
Missing include See merge request kai/observables!7
fweik
reviewed
May 18, 2020
Naming is hard, renaming too ;) |
fweik
reviewed
May 18, 2020
KaiSzuttor
force-pushed
the
observables
branch
3 times, most recently
from
3eeea69 to
49c7be0
Compare
|
why does the integrator test fail? https://gitlab.icp.uni-stuttgart.de/espressomd/espresso/-/jobs/230703 |
|
Timeout could be a technical problem. Did you check locally (with more than one core)? |
|
ok CI is green... @RudolfWeeber you can have a look again |
|
Doc is good except the comment on VS forces. Once that's done, we can go ahead with this. |
RudolfWeeber
previously approved these changes
May 20, 2020
fweik
reviewed
May 25, 2020
fweik
suggested changes
May 25, 2020
fweik
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/particle_observablesfor generic single particle observables