Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Sanitizer build with Ubuntu 20.04 #3636

Closed
wants to merge 18 commits into from
Closed

WIP: Sanitizer build with Ubuntu 20.04 #3636

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
bc403cb
CMake: Exclude some boost MPI from clang-tidy
RudolfWeeber Apr 6, 2020
eb2164e
CI: Add Ubuntu 20.04 build
RudolfWeeber Apr 6, 2020
79638aa
Formatting
RudolfWeeber Apr 6, 2020
c979dff
CI: Disable Cuda on Ubuntu 20.04 job
RudolfWeeber Apr 6, 2020
fc393d0
CI: Ubuntu 20.04 select clang
RudolfWeeber Apr 6, 2020
c1beb3d
Cython: build with -Wno-deprecated-declarations
RudolfWeeber Apr 6, 2020
c8b988c
UBSAN: Suppressions file
RudolfWeeber Apr 7, 2020
3b4eb1e
CI: Use UB Sanitizer suppressions in Ubuntu 20.04 job
RudolfWeeber Apr 7, 2020
2657aff
CI: Path to UBSAN supressions
RudolfWeeber Apr 7, 2020
9eab049
Merge branch 'python' into u2004
RudolfWeeber Apr 7, 2020
a88e7bd
Merge branch 'python' of git://github.com/espressomd/espresso into py…
RudolfWeeber Apr 9, 2020
a6f5040
Workaround Thrust compilation with Clang bug
RudolfWeeber Apr 9, 2020
1954401
CI: Enable CUDA on Ubuntu 20.04 sanitizer build
RudolfWeeber Apr 9, 2020
8af479d
Merge branch 'u2004' of ssh://github.com/RudolfWeeber/espresso into p…
RudolfWeeber Apr 9, 2020
12dcf03
Missing file
RudolfWeeber Apr 9, 2020
246afd4
Include file sorting
RudolfWeeber Apr 9, 2020
1c8c37d
CI: 2h time out for Ubuntu 20 sanitizer job
RudolfWeeber Apr 9, 2020
0ac6628
Clang+Thrust: Guard against double presence of workaround
RudolfWeeber Apr 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core/cuda_wrapper.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#if defined(__CUDACC__)

#include <cuda.h>
#include "clang_thrust_workaround.cuh"
Copy link
Member

@jngrad jngrad Apr 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file clang_thrust_workaround.cuh seems to be missing. Also, I just found out the issue was fixed in thrust 1.9.5 (I'm writing a report for them)

Suggested change
#include "clang_thrust_workaround.cuh"
#if THRUST_VERSION < 100905
#include "clang_thrust_workaround.cuh"
#endif

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my investigation: NVIDIA/thrust#1032 (comment); if CUDA 10.1 is shipped with thrust 1.9.5, we should install it on ICP machines and drop support for the combination Clang+CUDA10.0 is ESPResSo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RudolfWeeber sorry, I forgot that editing a message doesn't send an email. In my previous message, I meant to say that you probably forgot to commit file clang_thrust_workaround.cuh.


#endif

Expand Down