Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre commit plus new images #3622

Merged
merged 5 commits into from
Apr 2, 2020
Merged

Conversation

KaiSzuttor
Copy link
Member

@KaiSzuttor KaiSzuttor commented Apr 2, 2020

Contains #3619 #3606

Description of changes:

  • pulled out tool version checking to separate files
  • added configuration file for pre-commit
  • added cmake-format configuration and style fix
  • use new docker images created using GitHub Actions

@KaiSzuttor
Copy link
Member Author

$ maintainer/CI/fix_style.sh
clang-format.............................................................Passed
autopep8.................................................................Passed
cmake-format.............................................................Passed
executable flags.....................................(no files to check)Skipped

Works now... have to look at the last check tough

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #3622 into python will decrease coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3622   +/-   ##
======================================
- Coverage      87%     87%   -1%     
======================================
  Files         524     524           
  Lines       23414   23414           
======================================
- Hits        20603   20600    -3     
- Misses       2811    2814    +3
Impacted Files Coverage Δ
src/core/polymer.cpp 93% <0%> (-6%) ⬇️
src/core/particle_data.cpp 96% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3416043...7e1a082. Read the comment docs.

@KaiSzuttor
Copy link
Member Author

Works now... have to look at the last check tough

Checked, there is no file because no non-script file is executable

@jngrad jngrad added the DevOps label Apr 2, 2020
@jngrad jngrad added this to the Espresso 4.2 milestone Apr 2, 2020
@jngrad
Copy link
Member

jngrad commented Apr 2, 2020

The new workflow is now documented in the CI docs.

@KaiSzuttor
Copy link
Member Author

thanks @jngrad

@KaiSzuttor KaiSzuttor added the automerge Merge with kodiak label Apr 2, 2020
@kodiakhq kodiakhq bot merged commit d930a63 into espressomd:python Apr 2, 2020
@KaiSzuttor KaiSzuttor deleted the pre_commit_docker branch April 3, 2020 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge with kodiak DevOps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants