Core: Fix LB profile observable #3607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* respect min- and max_x,y,z rather than using 0 and box_size * remove off-by-one error for the number of sampling positions for certain choices of box size and sampling_delta and offset
Codecov Report
@@ Coverage Diff @@
## python #3607 +/- ##
=======================================
+ Coverage 87% 87% +<1%
=======================================
Files 525 525
Lines 23398 23398
=======================================
+ Hits 20580 20586 +6
+ Misses 2818 2812 -6
Continue to review full report at Codecov.
|
jngrad
reviewed
Mar 30, 2020
Merged
KaiSzuttor
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3603
This is probably the least invasive way to fix the issue.
LB and particle profile observables are consistent, when using the same min- and max_x,y,z and a sampling_offset of agrid/2.
Alternatively, the sampling_delta parameter could be removed, but then, min_x would have to be set to agrid/2 and max_x to box_l +agrid/2. That's probably more confusing.