-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix returned array shape for accumulator #3578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending the inheritance fix
just talked to @fweik. He prefers to implement a core function that returns the shape. I will have a look. |
I don't think this should be done on the python level. Determining the shape require knowledge of the core implementation, and should therefor be done there. |
772a6e6
to
c76f023
Compare
c76f023
to
65b23dc
Compare
Codecov Report
@@ Coverage Diff @@
## python #3578 +/- ##
======================================
- Coverage 88% 88% -1%
======================================
Files 524 524
Lines 23599 23611 +12
======================================
+ Hits 20777 20784 +7
- Misses 2822 2827 +5
Continue to review full report at Codecov.
|
Fixes part of #3577
Description of changes: