Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layered #3512

Merged
merged 3 commits into from
Feb 19, 2020
Merged

Layered #3512

merged 3 commits into from
Feb 19, 2020

Conversation

fweik
Copy link
Contributor

@fweik fweik commented Feb 19, 2020

Description of changes:

  • Removed layered topology

This only needed to exist for MMM2D, which was since removed. The same
functionality can be achieved by the regular domain composition using the
fully_connected flags.

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #3512 into python will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #3512    +/-   ##
=======================================
+ Coverage      86%     87%   +<1%     
=======================================
  Files         537     536     -1     
  Lines       24542   24177   -365     
=======================================
- Hits        21351   21058   -293     
+ Misses       3191    3119    -72
Impacted Files Coverage Δ
src/core/global.cpp 83% <ø> (+7%) ⬆️
src/core/electrostatics_magnetostatics/coulomb.cpp 80% <ø> (ø) ⬆️
src/core/cells.cpp 88% <ø> (-2%) ⬇️
src/core/cells.hpp 100% <ø> (ø) ⬆️
src/core/short_range_loop.hpp 100% <ø> (ø) ⬆️
src/core/actor/Actor.hpp 60% <0%> (ø) ⬆️
src/core/actor/DipolarDirectSum.hpp 88% <0%> (ø) ⬆️
src/core/actor/DipolarBarnesHut.hpp 80% <0%> (ø) ⬆️
src/core/metadynamics.cpp 7% <0%> (-4%) ⬇️
src/core/particle_data.cpp 95% <0%> (-2%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af75344...7639c29. Read the comment docs.

Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI

@jngrad jngrad added this to the Espresso 4.2 milestone Feb 19, 2020
@KaiSzuttor KaiSzuttor added the automerge Merge with kodiak label Feb 19, 2020
@kodiakhq kodiakhq bot merged commit cd66da0 into espressomd:python Feb 19, 2020
@fweik fweik deleted the layered branch August 27, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants