Cleanup cython further #3510
Merged
Cleanup cython further #3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transfer them to cellsystem.pxd.
Recent dependency inversions in the core have decoupled the global state from the implementation details of thermostats, integrators and cellsystems. These includes can be transferred from globals.pxd to the relevant .pxd files.
Codecov Report
@@ Coverage Diff @@
## python #3510 +/- ##
======================================
- Coverage 87% 87% -1%
======================================
Files 537 537
Lines 24433 24433
======================================
- Hits 21278 21277 -1
- Misses 3155 3156 +1
Continue to review full report at Codecov.
|
fweik
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3496
Reflect in the Python interface all dependency inversions that recently took place in the core.