Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CMake logic for tutorials #3486

Merged
merged 4 commits into from
Feb 16, 2020
Merged

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Feb 14, 2020

Description of changes:

  • modifying a tutorial dependency (figure or script) in the source directory will automatically update it in the build directory (fixes Make tutorial python scripts proper dependencies #3472)
  • tutorials are now fully independent of each other, e.g. make tutorial_04 only re-generates files for tutorial 04 in the build directory
  • the list of dependencies for targets tutorials, tutorials_html, tutorials_python are now automatically generated instead of being manually curated

Reduces the maintenance effort. Also, CMake files should not need
to know anything about the structure of included subdirectories.
Explicitly list all dependencies of Jupyter notebooks and make them
target dependencies, such that a copy in the build directory gets
updated whenever the original in the source directory has changed.
@jngrad jngrad added this to the Espresso 4.2 milestone Feb 14, 2020
@jngrad jngrad requested a review from KaiSzuttor February 14, 2020 21:30
@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #3486 into python will decrease coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3486   +/-   ##
======================================
- Coverage      87%     87%   -1%     
======================================
  Files         536     536           
  Lines       24400   24400           
======================================
- Hits        21247   21243    -4     
- Misses       3153    3157    +4
Impacted Files Coverage Δ
src/core/electrostatics_magnetostatics/p3m.cpp 84% <0%> (-1%) ⬇️
src/core/particle_data.cpp 97% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4612591...302a5c3. Read the comment docs.

@jngrad jngrad added the automerge Merge with kodiak label Feb 16, 2020
@kodiakhq kodiakhq bot merged commit cec08a2 into espressomd:python Feb 16, 2020
@jngrad jngrad deleted the fix-3472 branch January 18, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make tutorial python scripts proper dependencies
2 participants