Diamond Polymers in Python #3477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #3477 +/- ##
=======================================
+ Coverage 86% 87% +<1%
=======================================
Files 536 537 +1
Lines 24654 24460 -194
=======================================
- Hits 21335 21291 -44
+ Misses 3319 3169 -150
Continue to review full report at Codecov.
|
pkreissl
reviewed
Feb 12, 2020
testsuite/python/polymer_linear.py
Outdated
| @@ -21,7 +21,7 @@ | |||
| import espressomd.shapes | |||
|
|
|||
|
|
|||
| class PolymerPositions(ut.TestCase): | |||
| class LinearPolymerPolymerPositions(ut.TestCase): | |||
There was a problem hiding this comment.
LinearPolymerPositions?
There was a problem hiding this comment.
I think we the name of the testclass is actually not too important if the class has a docstring (which it always should have).
There was a problem hiding this comment.
it's a typo nonetheless, I will fix it
KaiSzuttor
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3459, Fixes #2897
Description of changes:
PR Checklist