Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ghost flag globals #3399

Merged
merged 9 commits into from
Jan 16, 2020
Merged

Removed ghost flag globals #3399

merged 9 commits into from
Jan 16, 2020

Conversation

fweik
Copy link
Contributor

@fweik fweik commented Jan 6, 2020

Description of changes:

  • Calculate required ghost data parts on the fly.
  • Reorganized some of the cell update code to make data
    parts passable as an argument.
  • Optimized some of the ghost flags.

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #3399 into python will increase coverage by <1%.
The diff coverage is 93%.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #3399    +/-   ##
=======================================
+ Coverage      86%     86%   +<1%     
=======================================
  Files         538     538            
  Lines       25233   25282    +49     
=======================================
+ Hits        21755   21804    +49     
  Misses       3478    3478
Impacted Files Coverage Δ
src/core/communication.hpp 100% <ø> (ø) ⬆️
src/core/shapes/Torus.hpp 80% <ø> (ø) ⬆️
src/core/cells.hpp 100% <ø> (ø) ⬆️
src/core/particle_data.hpp 100% <ø> (ø) ⬆️
src/core/statistics.hpp 87% <ø> (ø) ⬆️
src/core/ghosts.hpp 100% <ø> (ø) ⬆️
...re/electrostatics_magnetostatics/p3m_send_mesh.cpp 100% <ø> (ø) ⬆️
...re/electrostatics_magnetostatics/p3m_send_mesh.hpp 100% <ø> (ø) ⬆️
src/core/energy_inline.hpp 67% <ø> (ø) ⬆️
src/core/global.cpp 83% <ø> (ø) ⬆️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8df7114...9d0ddf9. Read the comment docs.

@fweik fweik requested a review from RudolfWeeber January 7, 2020 08:59
@fweik fweik changed the title WIP: Ghost flags Removed ghost flag globals Jan 7, 2020
@RudolfWeeber RudolfWeeber added the automerge Merge with kodiak label Jan 16, 2020
@kodiakhq kodiakhq bot merged commit 102d00c into espressomd:python Jan 16, 2020
@jngrad jngrad added this to the Espresso 4.2 milestone Jan 20, 2020
@fweik fweik deleted the ghost_flags branch January 22, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge with kodiak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants