Fix velocity Verlet interface #3388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting up the NPT integrator, then the VV integrator, the core integrator remains on NPT. Since NVT and VV are the same, we can set the core integrator to NVT when the interface is set to VV.
Codecov Report
@@ Coverage Diff @@
## python #3388 +/- ##
======================================
Coverage 86% 86%
======================================
Files 537 537
Lines 25287 25287
======================================
Hits 21806 21806
Misses 3481 3481
Continue to review full report at Codecov.
|
KaiSzuttor
approved these changes
Dec 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug found in #3271.
Same as #3274, but for the development branch.