Dd fix #3377
Merged
Dd fix #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #3377 +/- ##
=======================================
+ Coverage 86% 86% +<1%
=======================================
Files 537 537
Lines 25283 25285 +2
=======================================
+ Hits 21805 21807 +2
Misses 3478 3478
Continue to review full report at Codecov.
|
jngrad
reviewed
Dec 12, 2019
|
Why delete the python test? You just had to add self.system.box_l = [50.0, 50.0, 50.0]
self.system.cell_system.skin = 0.4at the beginning of the method in c14db8b and it would have worked (I just tried it). |
|
Ah, I missed the skin. |
|
sorry I just tried an api call |
jngrad
approved these changes
Dec 12, 2019
|
bors r=+ p=19106272730 |
|
bors r=+ p=1910627273 |
bors bot
added a commit
that referenced
this pull request
Dec 12, 2019
3377: Dd fix r=+ a=fweik Fixes #3376. Description of changes: - Calculated cell index in a way such that all nodes agree on the cell a particle belongs into (independently of rounding errors). Co-authored-by: Florian Weik <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3376.
Description of changes:
a particle belongs into (independently of rounding errors).