Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: Fixed false positive compiler warnings occuring for some combi… #3303

Merged
merged 1 commit into from
Nov 13, 2019
Merged

utils: Fixed false positive compiler warnings occuring for some combi… #3303

merged 1 commit into from
Nov 13, 2019

Conversation

fweik
Copy link
Contributor

@fweik fweik commented Nov 13, 2019

…nations of gcc and boost

@fweik fweik requested a review from jngrad November 13, 2019 16:55
@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #3303 into python will decrease coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3303   +/-   ##
======================================
- Coverage      86%     86%   -1%     
======================================
  Files         536     536           
  Lines       25564   25564           
======================================
- Hits        21995   21993    -2     
- Misses       3569    3571    +2
Impacted Files Coverage Δ
src/utils/tests/memcpy_archive_test.cpp 100% <100%> (ø) ⬆️
src/core/electrostatics_magnetostatics/p3m.cpp 86% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d700908...9be9bac. Read the comment docs.

@jngrad
Copy link
Member

jngrad commented Nov 13, 2019

bors r+

bors bot added a commit that referenced this pull request Nov 13, 2019
3300: List Python3 dependencies r=fweik a=jngrad

Follow-up to #3093

List the minimal version numbers that are supported for dependent Python modules.

Please note `requirements.txt` does not have to list strict dependencies, optional packages are also allowed. Comments after a package name must have a whitespace before the `#` symbol.

3303: utils: Fixed false positive compiler warnings occuring for some combi… r=jngrad a=fweik

…nations of gcc and boost



Co-authored-by: Jean-Noël Grad <[email protected]>
Co-authored-by: Florian Weik <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 13, 2019

Build succeeded

@bors bors bot merged commit 9be9bac into espressomd:python Nov 13, 2019
@jngrad jngrad modified the milestones: 4.1.2, Espresso 4.1.2 Nov 18, 2019
@fweik fweik deleted the optionalub branch August 27, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants