Removed ENGINE shear torque calculation #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #3277 +/- ##
======================================
- Coverage 86% 85% -1%
======================================
Files 533 533
Lines 25577 25522 -55
======================================
- Hits 22002 21945 -57
- Misses 3575 3577 +2
Continue to review full report at Codecov.
|
|
Yes that's the one, thank you. |
|
Oh, then why did the test pass? |
fweik
changed the title
fweik
changed the title
fweik
changed the title
core/testsuite: engine_lb test fix from christophlohrmann
fweik
changed the title
RudolfWeeber
approved these changes
Oct 28, 2019
|
bors r=RudolfWeeber |
bors bot
added a commit
that referenced
this pull request
Oct 28, 2019
3277: Removed ENGINE shear torque calculation r=RudolfWeeber a=fweik @RudolfWeeber @christophlohrmann is this what you had in mind? If so the simplification is quite significant because all of the custom communication code for ENGINE can be removed. Also the LB coupling should now work in parallel. Description of changes: - Removed ENGINE shear torque calculation - Moved swimmer parameters into ParticleProperties - Removed custom communiication code for ENGINE - Adaped docs Co-authored-by: Florian Weik <[email protected]>
Build succeeded |
jngrad
added a commit
to jngrad/espresso
that referenced
this pull request
Nov 4, 2019
3277: Removed ENGINE shear torque calculation Description of the partial merge: - Removed rotational_friction - Fixed engine_lb test - Adaped docs Co-authored-by: Florian Weik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RudolfWeeber @christophlohrmann is this what you had in mind?
If so the simplification is quite significant because all of the custom
communication code for ENGINE can be removed. Also the LB coupling
should now work in parallel.
Description of changes: