core: virtual_sites: Removed default argument from virtual function and non-functional virtual COM feature #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaiSzuttor
approved these changes
Oct 15, 2019
jngrad
reviewed
Oct 15, 2019
Codecov Report
@@ Coverage Diff @@
## python #3250 +/- ##
======================================
- Coverage 85% 85% -1%
======================================
Files 528 528
Lines 25790 25790
======================================
- Hits 22148 22145 -3
- Misses 3642 3645 +3
Continue to review full report at Codecov.
|
|
I did not remove any feature. |
jngrad
reviewed
Oct 15, 2019
jngrad
changed the title
jngrad
approved these changes
Oct 15, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 15, 2019
3244: Update docs 4.1 r=fweik a=jngrad Provide links to Dockerfiles, fix links in 4.1 release notes, fix typos. 3250: core: virtual_sites: Removed default argument from virtual function and non-functional virtual COM feature r=jngrad a=fweik Description of changes: - Removed dead code (`VIRTUAL_SITES_COM`, `THERMOSTAT_IGNORE_NON_VIRTUAL`) - Removed default argument on virtual function Co-authored-by: Jean-Noël Grad <[email protected]> Co-authored-by: Florian Weik <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
VIRTUAL_SITES_COM,THERMOSTAT_IGNORE_NON_VIRTUAL)