Core: Correct maximum permissible skin in tune_skin() #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #3096 +/- ##
======================================
Coverage 83% 83%
======================================
Files 530 530
Lines 26100 26100
======================================
Hits 21915 21915
Misses 4185 4185
Continue to review full report at Codecov.
|
jngrad
approved these changes
Aug 22, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 22, 2019
3070: Thermalized bond philox r=jngrad a=KonradBreitsprecher Fixes the TB part of #2683 - Common philox counter for all thermalized bonds. Decorrelation via the bond partner IDs (not taking into account the bond ID). This was much easier to implement and is valid, as two (different) thermalized bonds on the same particle pair makes no sense. 3080: testsuite: add test for is_valid_type. r=jngrad a=KaiSzuttor Currently it is possible to give ```nan``` as values to the particle properties because in python a ```nan``` is of type ```float```. This PR adds a check for ```None```, ```inf``` and ```nan``` to the ```is_valid_type``` and tests for the correct behavior. 3096: Core: Correct maximum permissible skin in tune_skin() r=jngrad a=RudolfWeeber Fixes #2924 Fix according to the discussion in #2924 Co-authored-by: KonradBreitsprecher <[email protected]> Co-authored-by: Konrad Breitsprecher <[email protected]> Co-authored-by: Konrad Breitsprecher <[email protected]> Co-authored-by: Jean-Noël Grad <[email protected]> Co-authored-by: Kai Szuttor <[email protected]> Co-authored-by: Kai Szuttor <[email protected]> Co-authored-by: Rudolf Weeber <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2924
Fix according to the discussion in #2924