Max cut #3053
Merged
Max cut #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #3053 +/- ##
======================================
- Coverage 82% 82% -1%
======================================
Files 529 529
Lines 26086 26072 -14
======================================
- Hits 21445 21432 -13
+ Misses 4641 4640 -1
Continue to review full report at Codecov.
|
|
we should probably deactivate this clang-tidy warning... |
|
I think the point is valid. |
|
LGTM, except one doxygen thing
Please add doxygen for range |
|
@RudolfWeeber there is a merge conflict, |
Canceled |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Aug 9, 2019
3053: Max cut r=RudolfWeeber a=fweik Description of changes: - Replaced some globals related to cutoff calculation - Store range limits in cell_structure - Consistently use `INACTIVE_CUTOFF`/`-1.` for cutoffs of disabled kernels. Further refactoring is blocked by the fact that the short-range kernels with different cutoffs are fused together, and by the unclear resposibility for the verlet list. The performance hacks that mix everything together also do not help. Co-authored-by: Florian Weik <[email protected]> Co-authored-by: Jean-Noël Grad <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
INACTIVE_CUTOFF/-1.for cutoffsof disabled kernels.
Further refactoring is blocked by the fact that the short-range kernels
with different cutoffs are fused together, and by the unclear resposibility
for the verlet list. The performance hacks that mix everything together
also do not help.