Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Doxygen landing page #2993

Merged
merged 5 commits into from
Jul 25, 2019
Merged

Update Doxygen landing page #2993

merged 5 commits into from
Jul 25, 2019

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Jul 17, 2019

Fixes #2600, closes #294

Update Doxygen landing page and add a link to the Related Pages where detailed instructions are provided for developing new features in the C++ core.

@jngrad jngrad added this to the Espresso 4.1 milestone Jul 17, 2019
@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #2993 into python will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #2993   +/-   ##
======================================
  Coverage      82%     82%           
======================================
  Files         525     525           
  Lines       26806   26806           
======================================
  Hits        22014   22014           
  Misses       4792    4792

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 182020a...eeab576. Read the comment docs.

Copy link
Contributor

@RudolfWeeber RudolfWeeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jul 25, 2019
2984: Don't unroll loops with nontrivial loop bodies r=KaiSzuttor a=mkuron

Simple assignments and arithmetic are fine to unroll, but if there's a function call or a nested loop, unrolling is probably not useful

Follow-up to #2982.

2993: Update Doxygen landing page r=RudolfWeeber a=jngrad

Fixes #2600, closes #294

Update Doxygen landing page and add a link to the Related Pages where detailed instructions are provided for developing new features in the C++ core.

2998: Benchmarks reliability r=RudolfWeeber a=jngrad

Since 4.0 a few things changed in the CMake workflow (either in espresso CMake files, or in newer CMake releases) that broke the benchmark functionality:
- changing myconfig.hpp doesn't always cause a full project recompilation (rare)
- ctest sometimes runs benchmarks in parallel

The benchmark bash scripts were also brittle. They were both refactored based on `build_cmake.sh`:
- trap mechanism with clear error message
- another trap with cleanup action
- simplified CMake logic
- ctest runs benchmarks in serial
- erase /build/src before each compilation

Other changes:
- don't print debug energy values in the CSV output
- some column names were changed
- the [wiki documentation](https://github.com/espressomd/espresso/wiki/Development#benchmarking) was updated accordingly
    - and it now discusses condor on ICP machines
- reduce risk of LJ simulation crashing with a longer energy minimization
- add a benchmark for bonded interactions
- print more info in stdout (config file being processed, energy during LJ minimization and simulation)

Co-authored-by: Michael Kuron <[email protected]>
Co-authored-by: Kai Szuttor <[email protected]>
Co-authored-by: Jean-Noël Grad <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 25, 2019

Build succeeded

@bors bors bot merged commit eeab576 into espressomd:python Jul 25, 2019
@jngrad jngrad deleted the fix-2600 branch January 18, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doxygen landing page outdated Bring Developer Guide up to date
2 participants