Lb nodes generator #2917
Merged
Lb nodes generator #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test And moved the lbfluid.stress property from lbcpu to base class
KaiSzuttor
suggested changes
Jun 14, 2019
testsuite/python/lb.py
Outdated
| for k in range(n_nodes): | ||
| lb_nodes.append(self.lbf[i, j, k]) | ||
| for n in self.lbf.nodes(): | ||
| lb_nodes.append(n) |
There was a problem hiding this comment.
you can omit this step now, just use the generator directly
Codecov Report
@@ Coverage Diff @@
## python #2917 +/- ##
======================================
- Coverage 83% 83% -1%
======================================
Files 520 520
Lines 26923 26924 +1
======================================
Hits 22444 22444
- Misses 4479 4480 +1
Continue to review full report at Codecov.
|
KaiSzuttor
approved these changes
Jun 17, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 17, 2019
2917: Lb nodes generator r=KaiSzuttor a=RudolfWeeber @KaiSzuttor This also moves lbfluid(cpu).stress to the base class since it also applies to lbgpu. Co-authored-by: Rudolf Weeber <[email protected]> Co-authored-by: Kai Szuttor <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@KaiSzuttor
This also moves lbfluid(cpu).stress to the base class since it also applies to lbgpu.