Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LBGPU: Don't forget boundaries on on_cell_strucutre_change() #2736

Merged
merged 8 commits into from
Apr 19, 2019

Conversation

RudolfWeeber
Copy link
Contributor

+Test

Fixes #2728

@@ -364,7 +364,9 @@ void on_cell_structure_change() {
#endif /* ifdef DIPOLES */

#ifdef LB
lb_lbfluid_init();
if (lattice_switch == ActiveLB::CPU) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this call some interface function, instead of checking the lattice switch? Also how sure are you that no action should be taken for the GPU code in this case?

@RudolfWeeber
Copy link
Contributor Author

Further offline discussion yielded the following:
While the GPU forgets boundaries when the event is triggered,
the CPU LB forgets the flow field.

The LBCPU cannot cope with changes of the parallelizaiton, and local and global box shapes.
It also needs to react to changes of the md skin due to the halo size.

The current event categories are too broad for this, so refactoring is needed, there. This also pertains to the Walberla LB integration.
Short-term, I'll introduce code to throw a runtime error, when the
event is triggered.

* LB GPU: ignore
* LB CPU: Runtime error
@RudolfWeeber
Copy link
Contributor Author

This should go into 4.0.2

@fweik fweik added this to the Espresso 4.0.2 milestone Apr 17, 2019
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #2736 into python will decrease coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #2736   +/-   ##
======================================
- Coverage      80%     80%   -1%     
======================================
  Files         508     508           
  Lines       27073   27076    +3     
======================================
- Hits        21822   21812   -10     
- Misses       5251    5264   +13
Impacted Files Coverage Δ
src/core/event.cpp 95% <100%> (ø) ⬆️
src/core/grid_based_algorithms/halo.cpp 58% <0%> (-7%) ⬇️
src/core/grid_based_algorithms/lb_interface.cpp 74% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c8d12...751ac72. Read the comment docs.

@fweik fweik merged commit 903e4e6 into espressomd:python Apr 19, 2019
RudolfWeeber pushed a commit to RudolfWeeber/espresso that referenced this pull request Apr 23, 2019
LBGPU: Don't forget boundaries on on_cell_strucutre_change()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LB GPU does not apply velocity bc under unclear circumstances
3 participants