-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LBGPU: Don't forget boundaries on on_cell_strucutre_change() #2736
Conversation
@@ -364,7 +364,9 @@ void on_cell_structure_change() { | |||
#endif /* ifdef DIPOLES */ | |||
|
|||
#ifdef LB | |||
lb_lbfluid_init(); | |||
if (lattice_switch == ActiveLB::CPU) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this call some interface function, instead of checking the lattice switch? Also how sure are you that no action should be taken for the GPU code in this case?
Further offline discussion yielded the following: The LBCPU cannot cope with changes of the parallelizaiton, and local and global box shapes. The current event categories are too broad for this, so refactoring is needed, there. This also pertains to the Walberla LB integration. |
* LB GPU: ignore * LB CPU: Runtime error
c1572a7
to
20b8ffe
Compare
This should go into 4.0.2 |
Codecov Report
@@ Coverage Diff @@
## python #2736 +/- ##
======================================
- Coverage 80% 80% -1%
======================================
Files 508 508
Lines 27073 27076 +3
======================================
- Hits 21822 21812 -10
- Misses 5251 5264 +13
Continue to review full report at Codecov.
|
LBGPU: Don't forget boundaries on on_cell_strucutre_change()
+Test
Fixes #2728