Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EK python interface fix #2486

Merged
merged 2 commits into from
Jan 31, 2019
Merged

EK python interface fix #2486

merged 2 commits into from
Jan 31, 2019

Conversation

itischler
Copy link
Contributor

Fixes #

Description of changes:

PR Checklist

  • Tests?
    • Interface
    • Core
  • Docs?

@codecov
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #2486 into python will decrease coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           python   #2486     +/-   ##
========================================
- Coverage      71%     71%     -1%     
========================================
  Files         483     486      +3     
  Lines       28922   30360   +1438     
========================================
+ Hits        20765   21620    +855     
- Misses       8157    8740    +583
Impacted Files Coverage Δ
src/core/constraints/HomogeneousMagneticField.cpp 80% <0%> (-20%) ⬇️
src/core/RuntimeError.cpp 84% <0%> (-16%) ⬇️
.../core/electrostatics_magnetostatics/p3m-common.cpp 67% <0%> (-6%) ⬇️
src/core/pressure_inline.hpp 37% <0%> (-5%) ⬇️
src/script_interface/Serializer.hpp 75% <0%> (-4%) ⬇️
src/core/energy.cpp 80% <0%> (-4%) ⬇️
src/core/electrostatics_magnetostatics/icc.cpp 64% <0%> (-4%) ⬇️
src/core/initialize.cpp 84% <0%> (-4%) ⬇️
src/core/debug.cpp 28% <0%> (-3%) ⬇️
src/core/shapes/Slitpore.cpp 43% <0%> (-3%) ⬇️
... and 141 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2654603...c2f0f7b. Read the comment docs.

@fweik fweik merged commit 030ac7f into espressomd:python Jan 31, 2019
@RudolfWeeber RudolfWeeber added this to the Espresso 4.0.2 milestone Mar 5, 2019
RudolfWeeber pushed a commit to RudolfWeeber/espresso that referenced this pull request Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants