Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core+Test: Changing the time step should not affect particle velocities #2480

Merged
merged 4 commits into from
Jan 30, 2019
Merged

Core+Test: Changing the time step should not affect particle velocities #2480

merged 4 commits into from
Jan 30, 2019

Conversation

RudolfWeeber
Copy link
Contributor

Fixes #2479

@codecov
Copy link

codecov bot commented Jan 29, 2019 •
edited
Loading

Codecov Report

Merging #2480 into python will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #2480    +/-   ##
=======================================
+ Coverage      71%     71%   +<1%     
=======================================
  Files         486     486            
  Lines       30367   30360     -7     
=======================================
+ Hits        21612   21620     +8     
+ Misses       8755    8740    -15
Impacted Files Coverage Δ
src/core/communication.cpp 77% <ø> (-1%) ⬇️
src/core/integrate.cpp 72% <ø> (-1%) ⬇️
src/core/grid_based_algorithms/lb.cpp 78% <0%> (ø) ⬆️
src/core/electrostatics_magnetostatics/p3m.cpp 83% <0%> (ø) ⬆️
src/core/domain_decomposition.cpp 98% <0%> (+1%) ⬆️
src/core/lattice.cpp 89% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71d657d...1fe7e46. Read the comment docs.

KaiSzuttor
KaiSzuttor reviewed Jan 29, 2019
View reviewed changes
Copy link
Member

@KaiSzuttor KaiSzuttor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some docstring what is being tested

@KaiSzuttor KaiSzuttor merged commit b858b75 into espressomd:python Jan 30, 2019
@RudolfWeeber RudolfWeeber added this to the Espresso 4.0.2 milestone Mar 5, 2019
RudolfWeeber pushed a commit to RudolfWeeber/espresso that referenced this pull request Mar 13, 2019
@KaiSzuttor @RudolfWeeber
Merge pull request espressomd#2480 from RudolfWeeber/integ_test_2
df1c2dd 
Core+Test: Changing the time step should not affect particle velocities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fweik fweik fweik approved these changes

@KaiSzuttor KaiSzuttor KaiSzuttor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Espresso 4.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@RudolfWeeber @fweik @KaiSzuttor