Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage wlre #2404

Merged

Conversation

jonaslandsgesell
Copy link
Member

partially Fixes #2071

@jonaslandsgesell
Copy link
Member Author

jonaslandsgesell commented Dec 7, 2018

The above patch is outdated. The current HEAD has autopep8 applied. Please restart the test which checks the style.

@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #2404 into python will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #2404    +/-   ##
=======================================
+ Coverage      72%     72%   +<1%     
=======================================
  Files         396     396            
  Lines       18631   18631            
=======================================
+ Hits        13454   13526    +72     
+ Misses       5177    5105    -72
Impacted Files Coverage Δ
src/core/reaction_ensemble.cpp 81% <0%> (+8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87fd43c...d343c7c. Read the comment docs.

@jonaslandsgesell
Copy link
Member Author

The only failing tests are due to LB, which is unrelated to this PR. Please merge for increased test coverage of the Wang-Landau Reaction ensemble.

@KaiSzuttor KaiSzuttor merged commit 6e5b328 into espressomd:python Dec 19, 2018
RudolfWeeber pushed a commit to RudolfWeeber/espresso that referenced this pull request Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants