Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Removed random includes and random forces in non-bonded interac… #2372

Merged
merged 2 commits into from
Nov 12, 2018
Merged

Conversation

fweik
Copy link
Contributor

@fweik fweik commented Nov 12, 2018

…tions.

Should not cause a behavior change.

@fweik fweik requested a review from KaiSzuttor November 12, 2018 15:01
@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #2372 into python will increase coverage by <1%.
The diff coverage is 57%.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #2372    +/-   ##
=======================================
+ Coverage      72%     72%   +<1%     
=======================================
  Files         395     395            
  Lines       18784   18764    -20     
=======================================
+ Hits        13581   13582     +1     
+ Misses       5203    5182    -21
Impacted Files Coverage Δ
src/core/object-in-fluid/affinity.hpp 3% <ø> (ø) ⬆️
src/core/cuda_interface.cpp 98% <ø> (ø) ⬆️
src/core/object-in-fluid/membrane_collision.hpp 18% <ø> (ø) ⬆️
src/core/bonded_interactions/quartic.hpp 0% <ø> (ø) ⬆️
src/core/bonded_interactions/harmonic_dumbbell.hpp 0% <0%> (ø) ⬆️
src/core/bonded_interactions/harmonic.hpp 100% <100%> (+14%) ⬆️
src/core/bonded_interactions/fene.hpp 100% <100%> (+24%) ⬆️
src/core/forces_inline.hpp 74% <0%> (ø) ⬆️
src/core/energy_inline.hpp 58% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f80bd28...3b99990. Read the comment docs.

@fweik fweik merged commit c5ce8a7 into espressomd:python Nov 12, 2018
@fweik fweik deleted the random branch November 12, 2018 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants