-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LB stokes sphere test case update #2366
Conversation
Codecov Report
@@ Coverage Diff @@
## python #2366 +/- ##
=======================================
+ Coverage 71% 71% +<1%
=======================================
Files 381 381
Lines 18905 18906 +1
=======================================
+ Hits 13587 13603 +16
+ Misses 5318 5303 -15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should perform this test for CPU LB aswell
testsuite/python/lb_stokes_sphere.py
Outdated
system.cell_system.skin = 0.4 | ||
|
||
# The temperature is zero. | ||
system.thermostat.set_lb(kT=0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has to be done in the test method because the guard for the feature does not catch this statement which is not available when neither LB
nor LB_GPU
is compiled in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure about that? I see that the thermostat should be set in the test method but skin is set within the main class in other test cases also (lb.py, lb_poiseuille.py)!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I only meant the thermostat
LB stokes sphere test case update
Fixes #2097
Description of changes:
PR Checklist