Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LB stokes sphere test case update #2366

Merged
merged 10 commits into from
Nov 6, 2018
Merged

LB stokes sphere test case update #2366

merged 10 commits into from
Nov 6, 2018

Conversation

jainka
Copy link

@jainka jainka commented Nov 6, 2018

Fixes #2097

Description of changes:

PR Checklist

  • [x ] Tests?
    • Interface
    • Core
  • Docs?

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #2366 into python will increase coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #2366    +/-   ##
=======================================
+ Coverage      71%     71%   +<1%     
=======================================
  Files         381     381            
  Lines       18905   18906     +1     
=======================================
+ Hits        13587   13603    +16     
+ Misses       5318    5303    -15
Impacted Files Coverage Δ
src/script_interface/lbboundaries/LBBoundary.hpp 75% <100%> (ø) ⬆️
src/core/communication.cpp 77% <0%> (ø) ⬆️
src/core/statistics_fluid.cpp 50% <0%> (+22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08a6c67...6ed1679. Read the comment docs.

Copy link
Member

@KaiSzuttor KaiSzuttor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should perform this test for CPU LB aswell

system.cell_system.skin = 0.4

# The temperature is zero.
system.thermostat.set_lb(kT=0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has to be done in the test method because the guard for the feature does not catch this statement which is not available when neither LB nor LB_GPU is compiled in.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure about that? I see that the thermostat should be set in the test method but skin is set within the main class in other test cases also (lb.py, lb_poiseuille.py)!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I only meant the thermostat

@KaiSzuttor KaiSzuttor merged commit 6b4478b into espressomd:python Nov 6, 2018
RudolfWeeber pushed a commit to RudolfWeeber/espresso that referenced this pull request Nov 26, 2018
LB stokes sphere test case update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants