-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #2326 #2354
fixes #2326 #2354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although LB_ELECTROHYDRODYNAMICS
implies LB
, we should guard correctly. Thus: #ifdef LB_ELECTROHYDRODYNAMICS && ( defined(LB) || defined(LB_GPU))
Codecov Report
@@ Coverage Diff @@
## python #2354 +/- ##
=======================================
+ Coverage 71% 71% +<1%
=======================================
Files 381 381
Lines 18905 18905
=======================================
+ Hits 13567 13587 +20
+ Misses 5338 5318 -20
Continue to review full report at Codecov.
|
This code is only relevant to the GPU, so this should be |
Yes, but as long as the CUDA flag is enabled the cuda_interface will be compiled and thus this will lead to this compile error |
Can be merged |
Fixes #2326
Description of changes:
PR Checklist