Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testsuite: coldet feature guard and test name #2344

Merged
merged 4 commits into from
Nov 7, 2018

Conversation

RudolfWeeber
Copy link
Contributor

fixes #2332

@fweik fweik added this to the Espresso 4.0.1 milestone Oct 28, 2018
@codecov
Copy link

codecov bot commented Oct 28, 2018

Codecov Report

Merging #2344 into python will decrease coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #2344   +/-   ##
======================================
- Coverage      71%     71%   -1%     
======================================
  Files         381     381           
  Lines       18905   18891   -14     
======================================
- Hits        13587   13573   -14     
  Misses       5318    5318
Impacted Files Coverage Δ
src/core/collision.cpp 80% <100%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 068323d...9f25c54. Read the comment docs.

by Utils::MPI::gathe_buffer and boost::mpi::bcast
Use my_left, which is always a valid position rather than sth depending on the colliding particles
@RudolfWeeber
Copy link
Contributor Author

Fixes #2332
Fixes #2231

@fweik fweik self-assigned this Nov 7, 2018
@fweik fweik merged commit 5d47c5e into espressomd:python Nov 7, 2018
RudolfWeeber pushed a commit to RudolfWeeber/espresso that referenced this pull request Nov 26, 2018
Testsuite: coldet feature guard and test name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COLLISION_DETECTION: Missing guards in test
2 participants