Always define q #2266
Merged
Always define q #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aim is to avoid undefined access to q when ELECTROSTATICS is not defined.
|
This probably means that a lot of |
KaiSzuttor
reviewed
Sep 14, 2018
src/core/particle_data.cpp
Outdated
| @@ -598,6 +598,10 @@ int set_particle_q(int part, double q) { | |||
| mpi_send_q(pnode, part, q); | |||
| return ES_OK; | |||
| } | |||
| #ifndef ELECTROSTATICS | |||
| const constexpr double ParticleProperties::q; | |||
There was a problem hiding this comment.
No, const is needed in C++11, constexpr only implies const in C++14 an newer.
There was a problem hiding this comment.
|
Should I hunt down the |
|
@pdebuyl that would be helpful. There is at least one for which the performance impact needs to be checked (the one in the pair force calculation). |
|
next week :-) |
Codecov Report
@@ Coverage Diff @@
## python #2266 +/- ##
======================================
Coverage 71% 71%
======================================
Files 377 377
Lines 18941 18941
======================================
Hits 13580 13580
Misses 5361 5361
Continue to review full report at Codecov.
|
fweik
approved these changes
Sep 24, 2018
RudolfWeeber
pushed a commit
to RudolfWeeber/espresso
that referenced
this pull request
Oct 15, 2018
Always define q
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2248 (tentative)
Description of changes:
qas a particle propertpyI file the PR now to get an idea of the CI result, as I could only test a limited number of configurations.
PR Checklist