Fix unit test without SSE instructions #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkuron
changed the title
fweik
approved these changes
Sep 14, 2018
RudolfWeeber
pushed a commit
to RudolfWeeber/espresso
that referenced
this pull request
Oct 15, 2018
Fix unit test without SSE instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in #2258 by @junghans.
This is due to SSE vs. i387 floating-point arithmetic. If I compile with
-msse -mfpmath=sseon i586, the test succeeds. If I use-mfpmath=387, it fails. This is not an issue on amd64 as SSE is mandatory there.Candidate for Espresso 4.0.1.