Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite: Check planar shear profile of LB #2263

Merged
merged 8 commits into from
Sep 18, 2018
Merged

testsuite: Check planar shear profile of LB #2263

merged 8 commits into from
Sep 18, 2018

Conversation

fweik
Copy link
Contributor

@fweik fweik commented Sep 13, 2018

No description provided.

@fweik fweik requested a review from KaiSzuttor September 13, 2018 13:52
@KaiSzuttor
Copy link
Member

Sooo... lets rewrite LBGPU? 😒

@fweik
Copy link
Contributor Author

fweik commented Sep 14, 2018

Well I don't know. Disable the test for GPU an tell nobody about it?
Actually I think only the conversion of the boundary velocities from MD to LB units is missing.

@fweik
Copy link
Contributor Author

fweik commented Sep 17, 2018

@KaiSzuttor

----------
x : :obj:`float`
Position from the left plane.
nu : :obj:`float`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add doc for t

h : :obj:`float`
Distance between the plates.
k_max: :obj:`int`
Maximum considered wave number.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add doc for returned value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sth. like

Returns
———-
:obj:`double` : Analytical velocity

Copy link
Contributor Author

@fweik fweik Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. But there is not return type as this is python. Depends on what you put in. That's also true for the other ones. In the test it is used with numpy arrays, but it would also work with floats.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shear rate.
h : :obj:`float`
Distance between the plates.
k_max: :obj:`int`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space after k_max

@fweik fweik merged commit c987656 into espressomd:python Sep 18, 2018
@fweik fweik deleted the lb_shear_test branch September 18, 2018 08:09
@RudolfWeeber RudolfWeeber added this to the Espresso 4.0.1 milestone Oct 15, 2018
RudolfWeeber pushed a commit to RudolfWeeber/espresso that referenced this pull request Oct 15, 2018
testsuite: Check planar shear profile of LB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants