Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised sphinx documentation #1785

Merged
merged 5 commits into from
Jan 30, 2018

Conversation

KonradBreitsprecher
Copy link
Contributor

@KonradBreitsprecher KonradBreitsprecher commented Jan 26, 2018

Introducing a much more structured sphinx documentation and layout.

TODO (Needs doc, probably python interface):

  • Introduction

    • Available simulation methods (Update)
  • Particles

  • Non-bonded interactions

    • Membrane-collision interaction (OIF)
    • Affinity interaction (OIF)
  • Bonded interactions

    • Quartic bond
    • Bonded coulomb
    • Subtracted Lennard-Jones bond
  • Electrostatics

    • Coulomb Ewald GPU (status/fate unclear)
    • Tuning Alpha Ewald GPU (status/fate unclear)
  • Magnetostatics / Dipolar interactions (needs doc)

    • Dipolar interaction
    • Dipolar P3M
    • Tuning dipolar P3M
    • Dipolar Layer Correction (DLC)
    • Dipolar all-with-all and no replicas (DAWAANR)
    • Magnetic Dipolar Direct Sum (MDDS) on CPU
  • System manipulation (find better name)

    • Fixing the center of mass
  • Single particle forces (constraints)

    • Setting the minimal distance to a constraint
  • Analysis

    • Direct analysis routines (Remove TCL reference and update)
    • Temperature of the LB fluid
    • Energies (Extend doc)
  • Chains (status/fate unclear)

    • Internal distances
    • Internal distances II (specific monomer)
    • Bond lengths
    • Form factor
  • Observables and correlators

    • Accumulators (Not documented)
    • Available observables (links and examples)
    • The correlation algorithm: multiple tau correlator (status, fate unclear)
  • Input and Output (status/fate unclear; David?)

  • Advanced Methods

    • Immersed Boundary Method for soft elastic objects (OIF)
    • Object-in-fluid (OIF)
  • Appendix

    • Reaction Ensemble (add examples; highlight that doc is in class description; move to Advanced methods)
    • Electrokinetics (shift from purely physical doc to python doc; move to Advanced methods)

Commented out (Keep in core for now, don't expose to user):

  • System

    • GHMC thermostat
  • Particles

    • Cross-linking polymers
    • Virtual sites in the center of mass of a molecule
    • (Virtual Sites) Additional features
  • Non-bonded interactions

    • Directional Lennard-Jones interaction
  • Electrostatics

    • Maxwell Equation Molecular Dynamics (MEMD)
  • Lattice Boltzmann

    • The Shan Chen bicomponent fluid
    • SC as a thermostat
    • SC component-dependent interactions between particles
  • Analysis

    • Radial density map
    • Van-Hove autocorrelation function
    • Aggregation
    • Finding holes
  • Advanced methods:

    • nemd: Setting up non-equilibrium MD

Removed (Not supported anymore):

  • Setting up an icosaeder

Announced in / fixes #1778

@KonradBreitsprecher
Copy link
Contributor Author

ICP GitLab CI link down for some reason...

@mkuron
Copy link
Member

mkuron commented Jan 26, 2018

Try to amend the commit so it gets a new hash and then push again. It seems like the CI never got notified.

@KaiSzuttor
Copy link
Member

Maybe the webserver had been down when the pr was opened, i can trigger the webhook manually

@KaiSzuttor
Copy link
Member

didnt help, will have a look

@hmenke
Copy link
Member

hmenke commented Jan 27, 2018

Removed (Not supported anymore):

  • Parsing PDB Files

What about #1441?

@KonradBreitsprecher
Copy link
Contributor Author

@hmenke Yes I missed that. But the doc could be extended.

Reinserted 'Parsing PDB Files' section.
@codecov
Copy link

codecov bot commented Jan 27, 2018

Codecov Report

Merging #1785 into python will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #1785    +/-   ##
=======================================
+ Coverage      58%     58%   +<1%     
=======================================
  Files         416     417     +1     
  Lines       29268   29413   +145     
=======================================
+ Hits        17162   17277   +115     
- Misses      12106   12136    +30
Impacted Files Coverage Δ
src/core/observables/ProfileObservable.hpp 33% <0%> (-17%) ⬇️
src/core/observables/CylindricalDensityProfile.hpp 85% <0%> (-7%) ⬇️
...core/observables/CylindricalFluxDensityProfile.hpp 65% <0%> (-4%) ⬇️
...ndricalLBFluxDensityProfileAtParticlePositions.cpp 76% <0%> (-4%) ⬇️
src/core/p3m.cpp 82% <0%> (-1%) ⬇️
src/core/observables/LBRadialVelocityProfile.hpp 0% <0%> (ø) ⬆️
src/core/utils/coordinate_transformation.hpp 100% <0%> (ø)
src/core/observables/ForceDensityProfile.hpp 95% <0%> (ø) ⬆️
...rc/core/observables/CylindricalVelocityProfile.hpp 95% <0%> (ø) ⬆️
src/core/observables/FluxDensityProfile.hpp 94% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d65f3a...fa0f552. Read the comment docs.

@KaiSzuttor
Copy link
Member

gitlab webhook does not work because you deleted your python branch on github

@KaiSzuttor
Copy link
Member

i just fixed it, but still you may have deleted your branch unintentionally @KonradBreitsprecher

@KonradBreitsprecher
Copy link
Contributor Author

That happened while cleaning my github.. thanks @KaiSzuttor.

@fweik
Copy link
Contributor

fweik commented Jan 29, 2018

So the plan is to merge this now and then work on the docs on Friday? Or does anybody wants to still discuss the structure?

@fweik fweik merged commit a908c34 into espressomd:python Jan 30, 2018
@KonradBreitsprecher KonradBreitsprecher deleted the doc_restructure branch January 31, 2018 11:01
ashreyaj pushed a commit to ashreyaj/espresso that referenced this pull request Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure sphinx documentation
5 participants