Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bonded interactions cannot be deleted #4169

Closed
RudolfWeeber opened this issue Mar 20, 2021 · 4 comments · Fixed by #4350
Closed

Bonded interactions cannot be deleted #4169

RudolfWeeber opened this issue Mar 20, 2021 · 4 comments · Fixed by #4350

Comments

@RudolfWeeber
Copy link
Contributor

No description provided.

@RudolfWeeber
Copy link
Contributor Author

If they could be, serialization could be tested...

We should try to get this as part of moving bonded interactions to the script interface.

@fweik
Copy link
Contributor

fweik commented Apr 2, 2021

Can you explain a bit what you mean by that, and what the ideal behavior would be for you? Do you mean that bonded interactions can not be removed from the list of active interactions in the core?

@RudolfWeeber
Copy link
Contributor Author

RudolfWeeber commented Apr 2, 2021 via email

@fweik
Copy link
Contributor

fweik commented Apr 2, 2021

Thank you for clarifying the issue!

@kodiakhq kodiakhq bot closed this as completed in #4350 Oct 26, 2021
kodiakhq bot added a commit that referenced this issue Oct 26, 2021
Fixes #4225
Fixes #4377
Fixes #4169

Description of changes:
- Bonded interactions are now stored as ScriptInterface objects, are immutable and can be removed
- It is no longer possible to overwrite a bond object by a different type of bond (avoids segmentation faults)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants