Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight error in Gay-Berne Potential #3834

Closed
Kischy opened this issue Jul 30, 2020 · 3 comments · Fixed by #3839
Closed

Slight error in Gay-Berne Potential #3834

Kischy opened this issue Jul 30, 2020 · 3 comments · Fixed by #3839
Assignees

Comments

@Kischy
Copy link
Contributor

Kischy commented Jul 30, 2020

I think there is a slight error in the Gay-Berne Potential calculation in code and documentation:

The term (see http://espressomd.org/html/doc4.1.3/inter_non-bonded.html#gay-berne-interaction)
grafik
should really be
grafik.
Note the exponent.

This is accoring to the original equations in "J. G. Gay, B. J. Berne, Modification of the overlap potential to mimic a linear site–site potential, J. Chem. Phys. 1981, 74, 3316."

The equations in the original paper are:
grafik
and
grafik.

Am I correct or am I overlooking something?

@jngrad
Copy link
Member

jngrad commented Jul 30, 2020

I think you're right. However, a quick literature search reveals we are not the only one who dropped the nu exponent on epsilon0:

I couldn't find papers citing the Gay et Berne 1981 paper that included the nu exponent. Since epsilon0 is a constant, its nu exponent only rescales the potential and force. I would guess that's the reason why GB papers simply leave the exponent out.

We should add a citation to Gay et Berne 1981 plus a note that we use the convention of epsilon0 without exponent that is prevalent in the GB literature, in both the Sphinx documentation and the C++ source code.

@Kischy
Copy link
Contributor Author

Kischy commented Jul 30, 2020

Ok, sounds good.

@jngrad
Copy link
Member

jngrad commented Jul 30, 2020

Thanks for pointing out that discrepancy. I'll open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants