Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Current" observable wrong #3679

Closed
KaiSzuttor opened this issue Apr 22, 2020 · 3 comments · Fixed by #3973
Closed

"Current" observable wrong #3679

KaiSzuttor opened this issue Apr 22, 2020 · 3 comments · Fixed by #3973
Assignees
@KaiSzuttor
Milestone
Espresso 4.2.0

Comments

@KaiSzuttor
Copy link
Member

The observable is currently defined as

which has dimensions [length] [charge] [time]^-1. whereas electric current has units of [charge][time]^-1
@KaiSzuttor
Copy link
Member Author

actually what is called Current in the espresso observable is the current density times the volume

@RudolfWeeber RudolfWeeber added this to the Espresso 4.2 milestone Oct 24, 2020
@RudolfWeeber
Copy link
Contributor

@KaiSzuttor, could you please make a decision with regards to the Current observable.
Remove? Devide by volume and rename to CurrentDensity?

@RudolfWeeber
Copy link
Contributor

Will be removed due to wrong units/name. Use FluxDensityProfile instead

@KaiSzuttor KaiSzuttor self-assigned this Oct 26, 2020
@KaiSzuttor KaiSzuttor mentioned this issue Oct 26, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #3973 Oct 26, 2020
kodiakhq bot added a commit that referenced this issue Oct 26, 2020
@kodiakhq
Remove 'Current' observable. (#3973)
0156f3d 
Fixes #3679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaiSzuttor KaiSzuttor

Labels
None yet
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging a pull request may close this issue.

Remove 'Current' observable. KaiSzuttor/espresso
2 participants
@RudolfWeeber @KaiSzuttor